a/ziglings
1
0
Fork 0
mirror of https://codeberg.org/andyscott/ziglings.git synced 2024-12-22 14:03:10 -05:00
Code Issues Projects Releases Packages Wiki Activity

build: in ZiglingStep.check_output panic in case of OOM

Browse source 
This is necessary since, when trimLines returns `std.mem.Allocator.Error`,
no error message will be displayed to the user.

An alternative is to use `std.Build.Step.fail`, but using @panic("OOM")
is simpler and consistent with existing code.
This commit is contained in:
Manlio Perillo 2023-05-20 07:21:11 +02:00
parent d0de9e5348
commit 3e38a4fc84
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
build.zig
View file

@ -304,7 +304,7 @@ const ZiglingStep = struct {
// Validate the output. // Validate the output.
// NOTE: exercise.output can never contain a CR character. // NOTE: exercise.output can never contain a CR character.
// See https://ziglang.org/documentation/master/#Source-Encoding. // See https://ziglang.org/documentation/master/#Source-Encoding.
const output = try trimLines(b.allocator, raw_output); const output = trimLines(b.allocator, raw_output) catch @panic("OOM");
const exercise_output = self.exercise.output; const exercise_output = self.exercise.output;
if (!std.mem.eql(u8, output, self.exercise.output)) { if (!std.mem.eql(u8, output, self.exercise.output)) {
return self.step.fail( return self.step.fail(