From 4b58de26d3196a9c344afb9bfea0a50afaf248f5 Mon Sep 17 00:00:00 2001 From: Manlio Perillo Date: Fri, 7 Apr 2023 16:22:52 +0200 Subject: [PATCH] eowyn: always quote variables Quote all the variables, even though we know that it is safe. Fix coding style. --- patches/eowyn.sh | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/patches/eowyn.sh b/patches/eowyn.sh index a036acf..bc57249 100755 --- a/patches/eowyn.sh +++ b/patches/eowyn.sh @@ -14,7 +14,7 @@ # # We check ourselves before we wreck ourselves. -if [ ! -f 'patches/eowyn.sh' ] +if [ ! -f patches/eowyn.sh ] then echo "But I must be run from the project root directory." exit 1 @@ -27,18 +27,17 @@ mkdir -p patches/healed for broken in exercises/*.zig do # Remove the dir and extension, rendering the True Name. - true_name=$(basename $broken .zig) + true_name=$(basename "$broken" .zig) patch_name="patches/patches/$true_name.patch" - - if [ -f $patch_name ] + if [ -f "$patch_name" ] then # Apply the bandages to the wounds, grow new limbs, let # new life spring into the broken bodies of the fallen. - echo Healing $true_name... - patch --output=patches/healed/$true_name.zig $broken $patch_name + echo Healing "$true_name"... + patch --output="patches/healed/$true_name.zig" "$broken" "$patch_name" else - echo Cannot heal $true_name. No patch found. + echo Cannot heal "$true_name". No patch found. fi done