Commit graph

595 commits

Author SHA1 Message Date
Chris Boesch
39eaea027d fixed error time-out minutes 2023-04-26 19:47:35 +02:00
Chris Boesch
df52b7be61 step names addes and switched to checkout v3 2023-04-26 19:40:16 +02:00
Chris Boesch
cf3343e6df step names added and switched to checkout v3 2023-04-26 19:36:58 +02:00
Chris Boesch
6675fad34d fixed fail-fast error 2023-04-26 11:44:49 +02:00
Chris Boesch
d6c5d3e510 strategy error fixed 2023-04-26 11:37:31 +02:00
Chris Boesch
4fee940778 timeout error fixed 2023-04-26 11:35:19 +02:00
Chris Boesch
a703faa8e4 Merge pull request #259 from perillo/improve-github-workflows
workflows: improve the jobs configuration
2023-04-26 09:13:53 +00:00
Chris Boesch
65f3672ca5 back to checkout@2 2023-04-26 11:13:19 +02:00
Chris Boesch
f7e49d8c34 back to checkout@v2 2023-04-26 11:05:21 +02:00
Manlio Perillo
fa335d4166 workflows: improve the jobs configuration
Reduce the timeout to 30 minutes for all the jobs, since it is enough.

Set strategy.fail-fast to false, so that we can see the full logs.
2023-04-26 10:55:36 +02:00
Chris Boesch
232002f30f Merge pull request #254 from chrboesch/tools
Replacing Python-Tools with Zig-Tools
2023-04-25 21:46:12 +00:00
Chris Boesch
fa28aedfe1 Merge pull request #258 from chrboesch/eowyn
Version number added.
2023-04-25 21:37:55 +00:00
Chris Boesch
f69cfc3b88 Version number added. 2023-04-25 23:34:56 +02:00
Chris Boesch
cbf265ab98 Merge pull request #257 from chrboesch/eowyn
Added a loop for the formatting test, so we can see where errors happen.
2023-04-25 21:23:02 +00:00
Chris Boesch
0ac3646e9c Added a loop for the formatting test, so we can see where errors happen. 2023-04-25 23:21:01 +02:00
Chris Boesch
213d0712a5 replaced update-patches.py with update-patches.zig 2023-04-25 21:35:18 +02:00
Chris Boesch
c43ade9677 Merge pull request #255 from perillo/improve-ci-more
Improve ci more
2023-04-25 18:32:48 +00:00
Chris Boesch
58e28761be Merge pull request #256 from perillo/improve-more-2
More improvements
2023-04-25 18:31:12 +00:00
Chris Boesch
7470c29475 Python isn't necessary 2023-04-25 20:23:27 +02:00
Manlio Perillo
cac7391247 .gitattributes: remove support for old files, add python
Remove support for old .h, .cpp and .bat files.

Set eol mode to lf for Python scripts.

Closes #252
2023-04-25 16:13:59 +02:00
Manlio Perillo
9273fe2dd8 .gitignore: add zig-out, remove vim backup and swap files
Add the zig-out directory, since the install step is available.

Remove the vim backup and swap files, since it is possible to configure
vim to use a custom directory.

Ensure all the directories are anchored to the root directory.

Closes #251
2023-04-25 16:13:38 +02:00
Manlio Perillo
6effa7fe84 workflow: add a test job to ci.yml
Add a job to run the ziglings unit tests, using `zig build test`.
2023-04-25 15:35:42 +02:00
Manlio Perillo
b5036b776a workflows: use actions/checkout@v3
Use the new version of actions/checkout, since all Github Actions will
begin running on Node16 instead of Node12.

See https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
2023-04-25 15:13:38 +02:00
Manlio Perillo
49e7c51f9a Fix formatting in exercise 99
The non-conforming formatting was not detected by the eowyn.sh script,
due to a bug.
2023-04-25 14:56:07 +02:00
Manlio Perillo
fd6f3eebbb eowyn.sh: set the -e option
Currently, `zig fmt` exit status is ignored, making it useless.
Ensure that the script terminates early if there is an error.

Print a message to stdout before executing `zig fmt`, in order to make
the possible error more visible.
2023-04-25 14:52:05 +02:00
Manlio Perillo
4b58de26d3 eowyn: always quote variables
Quote all the variables, even though we know that it is safe.

Fix coding style.
2023-04-25 12:58:46 +02:00
Chris Boesch
cffbbff8bd replaced check-exercises.pu with check-exercises.zig 2023-04-25 12:13:58 +02:00
Chris Boesch
752efd891d Merge pull request #250 from perillo/improve-test-coverage-2
Improve test coverage
2023-04-24 15:56:51 +00:00
Chris Boesch
64d90c3397 timeout to 60 minutes 2023-04-24 17:43:55 +02:00
Manlio Perillo
4f690b074a test: add a test for zig build -Dn=1
Add a test for `zig build -Dn=1` in order to test that a broken exercise
will print an hint.
2023-04-24 13:03:52 +02:00
Manlio Perillo
5b2e842157 test: change the order of zig build options
In test case 1 and 2, move the -Dhealed option before the -Dn option,
for consistency.

Fix a typo in cmd.setName in test case 1 and 2.

Remove a confusing comment in test case 1.
2023-04-24 12:19:00 +02:00
Manlio Perillo
131772edd7 test: add test for zig build and zig build -Dn=1 start
Add tests for `zig build` and `zig build -Dn=1 start`, in order to test
that the all the exercises are processed in the correct order.
2023-04-24 11:59:08 +02:00
Manlio Perillo
3dd7cdcb3b build: make exercise output more reliable
Currently, ZiglingStep prints the raw exercise output.  This is not a
problem when executing `zig build` from the shell, but in a unit test it
is necessary to know when the exercise output ends.

Document that Exercise.output should not have trailing whitespace.
Ensure this is true by adding a check in the validate_exercises
function.

Remove trailing whitespace in exercises 68 and 99.

Simplify the output validation in ZiglingStep.makeInternal.
Checking that the length of the actual and expected output is the same
is not necessary, since trailing whitespace has been removed.  Simply do
an exact comparison.

Print the trimmed exercise output, instead of the raw output.
This will ensure that the exercise output always ends with only one LF
character.

Fix some small coding style issues.
2023-04-24 11:31:16 +02:00
Manlio Perillo
cec0aa51db test: fix incorrect cleanup code
The current cleanup code is incorrect, since it may delete the healed
directory while one test case is running.

The solution is to make each test case isolate, with its own setup and
teardown.  Unfortunately it is currently not possible, since each test
case modify the same directory.

Disable the cleanup step, until a better solution is found.
2023-04-24 10:32:08 +02:00
Manlio Perillo
108c145bdd test: refactorize the code
Currently, if there is an error when creating the patches/healed
directory, the error message will be printed on stderr, but the build
runner will report the test as being successful.

Add the fail function and the FailStep, so that the error will be
correctly handled by the build runner.

Remove the PatchStep, and instead add the heal function so that all the
exercises are healed before starting the tests.

The heal function executes at the configuration phase, but the possible
error is handled by the build runner.
2023-04-24 10:31:06 +02:00
Dave Gauer
2775d21ed0 Another README coverage list edit
I still had C interop under stdlib, which it isn't.
2023-04-23 19:43:26 -04:00
Dave Gauer
960da57e68 Tweaked README coverage list 2023-04-23 19:16:03 -04:00
Dave Gauer
346e6b00cd Updated README and CONTRIBUTING to reflect reality 2023-04-23 19:12:15 -04:00
Dave Gauer
42c430a0c0 Ex 099 format instructions to 65 columns, wording, examples 2023-04-23 18:54:43 -04:00
Chris Boesch
99891b53fb Update 099_formatting.zig
typo fixed
2023-04-19 22:14:06 +02:00
Chris Boesch
4435cebe7a Merge pull request #247 from chrboesch/formatting
added first formatting exercise
2023-04-19 22:09:32 +02:00
Chris Boesch
d6d30934db added first formatting exercise 2023-04-19 21:57:37 +02:00
Chris Boesch
2ed24ab3cf Merge pull request #234 from perillo/improve-ci
Improve CI
2023-04-19 15:25:12 +02:00
Manlio Perillo
c7697a4282 Ensure the patches are up-to-date and consistent
Add the update-patches.py tool.

Update all the patches, so that the files are up-to-date and use the
same patch file format.
2023-04-18 18:16:19 +02:00
Manlio Perillo
7d7be0482c eowyn: run zig fmt --check before zig build
Update the eowyn.sh script to check the healed exercises formatting,
before running `zig build`.
2023-04-18 18:16:19 +02:00
Manlio Perillo
6b17a18893 Ensure the exercises use the canonical format
Add the check-exercises.py tool in the new tools directory.  It is used
to check that the exercises are correctly formatted, printing on stderr
the invalid ones and the diff in the unified format.

Update the exercises that don't use the canonical zig fmt format.

Update some patches that cause the generated zig file to be incorrectly
formatted.
2023-04-18 18:16:19 +02:00
Manlio Perillo
b59bef29b9 ci: add a CI workflow
Add a new github workflow named CI.

Add a job named compat, checking that and old Zig compiler will not fail
with a compiler error, but instead will print an useful error message.
2023-04-18 18:16:19 +02:00
Chris Boesch
b84217161c Merge pull request #246 from perillo/build-restore-compatibility-2
build: restore compatibility with old Zig compilers
2023-04-18 18:06:41 +02:00
Manlio Perillo
30db9d105a build: avoid intermixed messages on the same line
In same cases, the progress messages from the compiler are intermixed
with the messages printed by ZiglingStep.

This intermixing appears in two cases:
  - when printing, e.g., the message "Checking 0_arrays2.zig..."
  - when printing the compiler errors

Closes #230
2023-04-18 14:43:17 +02:00
Manlio Perillo
c6e055dd83 build: don't print errors in ZiglingStep.eval
Move the code for printing compiler errors and messages to the new
ZiglingStep.printErrors method.

Call printErrors in the Zigling.doCompile method, both in the normal and
error flow.

When handling an error from the Zig IPC, add the case when the compiler
was unable to return the executable path.

Before using the IPC, the error was
  "The following command exited with error code 1"
now it is
  "The following command failed to communicate the compilation result"
2023-04-18 12:57:03 +02:00