Commit graph

713 commits

Author SHA1 Message Date
Manlio Perillo
3dd7cdcb3b build: make exercise output more reliable
Currently, ZiglingStep prints the raw exercise output.  This is not a
problem when executing `zig build` from the shell, but in a unit test it
is necessary to know when the exercise output ends.

Document that Exercise.output should not have trailing whitespace.
Ensure this is true by adding a check in the validate_exercises
function.

Remove trailing whitespace in exercises 68 and 99.

Simplify the output validation in ZiglingStep.makeInternal.
Checking that the length of the actual and expected output is the same
is not necessary, since trailing whitespace has been removed.  Simply do
an exact comparison.

Print the trimmed exercise output, instead of the raw output.
This will ensure that the exercise output always ends with only one LF
character.

Fix some small coding style issues.
2023-04-24 11:31:16 +02:00
Manlio Perillo
cec0aa51db test: fix incorrect cleanup code
The current cleanup code is incorrect, since it may delete the healed
directory while one test case is running.

The solution is to make each test case isolate, with its own setup and
teardown.  Unfortunately it is currently not possible, since each test
case modify the same directory.

Disable the cleanup step, until a better solution is found.
2023-04-24 10:32:08 +02:00
Manlio Perillo
108c145bdd test: refactorize the code
Currently, if there is an error when creating the patches/healed
directory, the error message will be printed on stderr, but the build
runner will report the test as being successful.

Add the fail function and the FailStep, so that the error will be
correctly handled by the build runner.

Remove the PatchStep, and instead add the heal function so that all the
exercises are healed before starting the tests.

The heal function executes at the configuration phase, but the possible
error is handled by the build runner.
2023-04-24 10:31:06 +02:00
Dave Gauer
2775d21ed0 Another README coverage list edit
I still had C interop under stdlib, which it isn't.
2023-04-23 19:43:26 -04:00
Dave Gauer
960da57e68 Tweaked README coverage list 2023-04-23 19:16:03 -04:00
Dave Gauer
346e6b00cd Updated README and CONTRIBUTING to reflect reality 2023-04-23 19:12:15 -04:00
Dave Gauer
42c430a0c0 Ex 099 format instructions to 65 columns, wording, examples 2023-04-23 18:54:43 -04:00
Chris Boesch
99891b53fb Update 099_formatting.zig
typo fixed
2023-04-19 22:14:06 +02:00
Chris Boesch
4435cebe7a Merge pull request #247 from chrboesch/formatting
added first formatting exercise
2023-04-19 22:09:32 +02:00
Chris Boesch
d6d30934db added first formatting exercise 2023-04-19 21:57:37 +02:00
Chris Boesch
2ed24ab3cf Merge pull request #234 from perillo/improve-ci
Improve CI
2023-04-19 15:25:12 +02:00
Manlio Perillo
c7697a4282 Ensure the patches are up-to-date and consistent
Add the update-patches.py tool.

Update all the patches, so that the files are up-to-date and use the
same patch file format.
2023-04-18 18:16:19 +02:00
Manlio Perillo
7d7be0482c eowyn: run zig fmt --check before zig build
Update the eowyn.sh script to check the healed exercises formatting,
before running `zig build`.
2023-04-18 18:16:19 +02:00
Manlio Perillo
6b17a18893 Ensure the exercises use the canonical format
Add the check-exercises.py tool in the new tools directory.  It is used
to check that the exercises are correctly formatted, printing on stderr
the invalid ones and the diff in the unified format.

Update the exercises that don't use the canonical zig fmt format.

Update some patches that cause the generated zig file to be incorrectly
formatted.
2023-04-18 18:16:19 +02:00
Manlio Perillo
b59bef29b9 ci: add a CI workflow
Add a new github workflow named CI.

Add a job named compat, checking that and old Zig compiler will not fail
with a compiler error, but instead will print an useful error message.
2023-04-18 18:16:19 +02:00
Chris Boesch
b84217161c Merge pull request #246 from perillo/build-restore-compatibility-2
build: restore compatibility with old Zig compilers
2023-04-18 18:06:41 +02:00
Manlio Perillo
30db9d105a build: avoid intermixed messages on the same line
In same cases, the progress messages from the compiler are intermixed
with the messages printed by ZiglingStep.

This intermixing appears in two cases:
  - when printing, e.g., the message "Checking 0_arrays2.zig..."
  - when printing the compiler errors

Closes #230
2023-04-18 14:43:17 +02:00
Manlio Perillo
c6e055dd83 build: don't print errors in ZiglingStep.eval
Move the code for printing compiler errors and messages to the new
ZiglingStep.printErrors method.

Call printErrors in the Zigling.doCompile method, both in the normal and
error flow.

When handling an error from the Zig IPC, add the case when the compiler
was unable to return the executable path.

Before using the IPC, the error was
  "The following command exited with error code 1"
now it is
  "The following command failed to communicate the compilation result"
2023-04-18 12:57:03 +02:00
Manlio Perillo
b39c7e61ef build: restore compatibility support again
Commit e214c44 (build: update ZiglingStep to the new API) broke again
the compatibility support for old compilers, due to the use of the
multi-object for loop syntax.

Move the Zig IPC support code to src/ipc.zig.

Use the while statement, instead of the for statement.
2023-04-18 12:22:30 +02:00
Chris Boesch
9ff7f5ee69 Merge pull request #238 from perillo/update-zigling-step
Update ZiglingStep
2023-04-13 18:47:36 +02:00
Manlio Perillo
e3c5cb2175 build: update ZiglingStep to the new API
Update the code to the breaking change in ziglang
commit c96cb98ad (CLI: remove --enable-cache option).

Replace the --enable-cache option with the --listen=- option and use the
Zig IPC to get the path to the executable.

Closes #236
2023-04-13 18:39:51 +02:00
Manlio Perillo
e91c7a24f2 build: disable special case for zig build -Dhealed
The special case was added because it was used by the Eowyn github
workflow.

As a side effect, however, it prevents testing the normal case used by
users.

Disable it, until a better solution is found.
2023-04-13 17:47:17 +02:00
Chris Boesch
540042576e Update README.md 2023-04-13 10:41:34 +02:00
Chris Boesch
3b3f802cc8 Merge pull request #237 from chrboesch/main
added cname
2023-04-13 09:57:50 +02:00
Chris Boesch
4b941892e1 Update CNAME 2023-04-12 21:07:38 +02:00
Chris Boesch
b7812b684f Update CNAME 2023-04-12 21:04:18 +02:00
Chris Boesch
10f0aa2100 Create CNAME 2023-04-12 20:56:32 +02:00
Chris Boesch
850ec0c164 Update README.md
url fixed
2023-04-12 19:32:34 +02:00
Chris Boesch
bf013df4bf Merge pull request #235 from perillo/update-to-version-0.11.0-dev.2560
Update the code to the new zig version
2023-04-12 19:02:43 +02:00
Manlio Perillo
bc98057d66 Update the code to the new zig version
Update the code to the breaking change in ziglang commit
60eabc0ec (std.Build.CompileStep: remove run() and install())

Update the zig version in the README.md file.
2023-04-12 18:50:30 +02:00
Chris Boesch
3121ebff30 Update 096_memory_allocation.zig
formatting
2023-04-12 17:14:18 +02:00
Chris Boesch
8eaf472959 Update 097_bit_manipulation.zig
formatting
2023-04-12 17:13:51 +02:00
Chris Boesch
ea330749ca Update 098_bit_manipulation2.zig
formatting
2023-04-12 17:10:54 +02:00
Chris Boesch
ecde85f5d5 Update README.md
set check for 'bit manipulation'
2023-04-12 17:09:03 +02:00
Chris Boesch
ffd3de2d01 Merge pull request #233 from chrboesch/bit_manipulation
added the second exercise for bit manipulation
2023-04-12 17:08:06 +02:00
Chris Boesch
9f48d84ac8 added the second exercise for bit manipulation 2023-04-12 17:00:26 +02:00
Chris Boesch
35765f9299 Merge pull request #232 from chrboesch/bit_manipulation
Bit manipulation
2023-04-12 15:52:27 +02:00
Chris Boesch
299418c314 added first exercise for bit manipulation 2023-04-12 15:47:20 +02:00
Chris Boesch
3c19500827 added first exercise for bit manipulation 2023-04-12 15:44:12 +02:00
Chris Boesch
1ccc86edd6 Merge pull request #224 from perillo/improve-build-more
build: enable full parallelism when -Dhealed is set
2023-04-12 15:27:48 +02:00
Manlio Perillo
47876e6371 build: make PrintStep thread safe
Update PrintStep to always printing to stderr, using std.debug.print, so
that the message is written atomically.

Note that currently it is not an issue, since PrintStep prints the
message before everything else.
2023-04-11 12:52:48 +02:00
Manlio Perillo
1ee8aabcf3 build: simplify the code when solving all the exercises
Initialize the first step in the chain to the header_step, instead of
making the code more complex handling the first step as a special case
in the for loop.
2023-04-11 12:45:55 +02:00
Manlio Perillo
be782af7a3 build: restore compatibility support
Commit 0d56ba3 (build: restore the exercise chain) broke the
compatibility support for old compilers, due to the use of the
multi-object for loop syntax.

Use the normal for loop syntax; the change still keep the code readable.

Use the variable `n`, instead of `i`, when referring to the exercise
number; this will improve the readability.

Closes #227
2023-04-11 12:45:55 +02:00
Manlio Perillo
647a24afae build: improve PrintStep, SkipStep and PatchStep names
Use lover case for the step names.

Add the exercise name for the SkipStep and PatchStep step name.
2023-04-11 12:45:55 +02:00
Manlio Perillo
c656536d3f build: simplify code and add tests
Simplify the code finding the exercise number from the exercise index,
when the -Dn option is set.  This is now possible since the exercise
numbers have no holes.

Add the validate_exercises function to check that exercise number are in
the correct order, and call it at the start of the build function.

Add tests, with 2 test cases.
2023-04-11 12:45:55 +02:00
Manlio Perillo
d43f19ded8 build: add support for skipping exercises
Currently, exercises not working with the current Zig compiler are
commented. This is problematic, since the exercise key and exercise
index are no longer consistent.

Add the skip field to the Excercise struct.  Update ZiglingStep to
support it and add a new SkipStep step to support it when using the
standard build step.
2023-04-11 12:45:55 +02:00
Manlio Perillo
67f369484c build: ensure the exercise links libc, when needed
When running, as an example, `zig build -Dhealed -Dn=93 test`, the build
fails, because the `test` step use the standard CompileStep, instead of
ZiglingStep.

Ensure that exercises using libc are correctly built.

Closes #229
2023-04-11 12:45:27 +02:00
Chris Boesch
7b37047c05 Update README.md 2023-04-09 19:40:39 +02:00
Chris Boesch
420acb781b Merge pull request #226 from chrboesch/adjust_advance
Adjustment of the 'Advanced usage' in the README
2023-04-09 19:39:24 +02:00
Chris Boesch
cff8aa2e52 closes https://github.com/ratfactor/ziglings/issues/223 2023-04-09 19:25:04 +02:00